Hi,
since a significant amount of time is spent reading PGN files, and for those managing a list, the PGNs being read are almost always the same with only minor additions, might it be a good idea to save all imported PGNs in a specific format (compressed or not) for quicker imports in subsequent sessions?
Alex
BayesElo recompiled and faster
Moderator: Ras
-
- Posts: 424
- Joined: Tue Dec 08, 2009 1:37 pm
- Location: Milan, Italy
- Full name: Alex Brunetti
-
- Posts: 2654
- Joined: Fri Nov 26, 2010 2:00 pm
- Location: Czech Republic
- Full name: Martin Sedlak
Re: BayesElo recompiled and faster
hi Alex,Brunetti wrote: ↑Mon Dec 23, 2024 11:19 am Hi,
since a significant amount of time is spent reading PGN files, and for those managing a list, the PGNs being read are almost always the same with only minor additions, might it be a good idea to save all imported PGNs in a specific format (compressed or not) for quicker imports in subsequent sessions?
Alex
probably, but there might be a better way - if you mean a pure rating list, then you don't really care about any moves/engine output in comments,
so it might be useful to filter and save a minimal pgn with results only and load that into bayeselo instead
(CCRL already does that for computing the rating history by day)
-
- Posts: 2654
- Joined: Fri Nov 26, 2010 2:00 pm
- Location: Czech Republic
- Full name: Martin Sedlak
Re: BayesElo recompiled and faster
ok, that doesn't sound too bad - I think Graham was talking about 9 hours iirc?Modern Times wrote: ↑Mon Dec 23, 2024 3:26 am The blitz update is already fairly reasonable - less than an hour and a half for me and Gabor, but the 4015 one is where a reduction will be really useful. I can't recall how long that took last time I ran it, maybe close to 3 hours.
-
- Posts: 3702
- Joined: Thu Jun 07, 2012 11:02 pm
Re: BayesElo recompiled and faster
I think he runs it on a SATA HDD. My times are NVME SSD. But it never ever took that long for me, even on slow hardware of the past. Just as well we turned off the pure lists, that adds a lot of time on top of that.
-
- Posts: 43988
- Joined: Sun Feb 26, 2006 10:52 am
- Location: Auckland, NZ
Re: BayesElo recompiled and faster
The first time one runs the update, it takes longer, I suspect.Modern Times wrote: ↑Mon Dec 23, 2024 12:51 pmI think he runs it on a SATA HDD. My times are NVME SSD. But it never ever took that long for me, even on slow hardware of the past. Just as well we turned off the pure lists, that adds a lot of time on top of that.
gbanksnz at gmail.com
-
- Posts: 424
- Joined: Tue Dec 08, 2009 1:37 pm
- Location: Milan, Italy
- Full name: Alex Brunetti
Re: BayesElo recompiled and faster
I already do this, but the loading time could be significantly improved, especially if you have numerous PGNs, and merging them all together has other drawbacks.
Alex
-
- Posts: 3702
- Joined: Thu Jun 07, 2012 11:02 pm
Re: BayesElo recompiled and faster
No it doesn't, unless you're including the time it takes on a clean installation checking all the historic pgns. Once they are checked they don't get checked again unless there is a trigger.Graham Banks wrote: ↑Mon Dec 23, 2024 12:59 pm The first time one runs the update, it takes longer, I suspect.
Anyway - I just ran 4015, it took 3 hrs 45 mins, a bit longer than I remember. I'm now running again with Martin's changes and we will see what time saving there is.
-
- Posts: 2654
- Joined: Fri Nov 26, 2010 2:00 pm
- Location: Czech Republic
- Full name: Martin Sedlak
Re: BayesElo recompiled and faster
ok then - another thing that comes to mind is parallelization - I can imagine either a special command to read multiple pgns at once
or simply make readpgn read async and then sync and merge on other commands
I'm a bit worried that this might slow down readpgn a bit along with increased memory usage - now I think definitely a separate command
maybe "readpgnasync" - so you would use say 20 readpgnasync in a row, then it'd sync on the next command and the rest would work as usual
as for a custom binary format - I don't like that idea much. but of course the download comes with source code so anything is possible
-
- Posts: 677
- Joined: Sat Jun 08, 2013 10:07 am
- Location: France
- Full name: Roland Chastain
Re: BayesElo recompiled and faster
Hi Martin.
Thank you for sharing. The program works very well.
I noticed a very small thing. It happened that I made a wrong manipulation and loaded an empty PGN file.
Here is the output of the program:
Maybe you could add a check in case someone loads by mistake an empty file, so that the program exit more gracefully?
Regards.
Roland
Thank you for sharing. The program works very well.
I noticed a very small thing. It happened that I made a wrong manipulation and loaded an empty PGN file.
Here is the output of the program:
Code: Select all
0 game(s) loaded, 0 game(s) with unknown result ignored.
terminate called after throwing an instance of 'std::bad_array_new_length'
what(): std::bad_array_new_length
Regards.
Roland
Qui trop embrasse mal étreint.
-
- Posts: 2654
- Joined: Fri Nov 26, 2010 2:00 pm
- Location: Czech Republic
- Full name: Martin Sedlak
Re: BayesElo recompiled and faster
hi Roland,
this thread is half a year old, I've since moved on to other things (I don't even know where I have the modified source code anymore)
the whole point was to speed up bayeselo for CCRL updates, fixing old bugs was never the goal, sorry.
I think this minor annoyance isn't a serious issue, but thanks for reporting anyway!
this thread is half a year old, I've since moved on to other things (I don't even know where I have the modified source code anymore)
the whole point was to speed up bayeselo for CCRL updates, fixing old bugs was never the goal, sorry.
I think this minor annoyance isn't a serious issue, but thanks for reporting anyway!