Hey, I actually got a chance to take a look, at what you did. Really nice work!
I quite like the Chat/ICS window. Plus how you managed to pop up the ICS text Menu is a really neat compromise to make something that works in GTK and Xaw. Although it works pretty good, gtk does have that actual right click menu with cut/copy/paste ect. Is there a way we could relay the ICS text menu into that in the gtk version?
------------------------
I noticed a few things though in your master branch.
Don't forget to put in that last bit of code with the renaming of items in the user conf file. in args.h
Code: Select all
case ArgFilename:
if(*(char**)ad->argLoc == NULL) break; // just in case
{ char buf[MSG_SIZ];
snprintf(buf, MSG_SIZ, "%s", *(char**)ad->argLoc);
#ifdef __APPLE__
if(strstr(buf, DATADIR) == buf)
snprintf(buf, MSG_SIZ, "~~%s", *(char**)ad->argLoc + strlen(DATADIR));
#endif
if (strchr(buf, '\"')) {
fprintf(f, OPTCHAR "%s" SEPCHAR "'%s'\n", ad->argName, buf);
} else {
fprintf(f, OPTCHAR "%s" SEPCHAR "\"%s\"\n", ad->argName, buf);
}
}
break;
case ArgBoardSize:
---------------------------------------
Next that old issue where if you open xboard twice it opens a million times is in your master branch. I suspect a suppression line must have been lost somewhere along the way. (it's works fine in the master-20140119 branch on savannah)
----------------------------------------
Lastly, with the new integrated ics menu, I tried replacing my .command scripts with .xop files as terminal won't be needed anymore. Only when the .xop file launches the ics with just:
I get an error
"Exiting: Got an end of file from keyboard"
If I hit OK, it closes xboard. If I close the window of the popup, xboard stays open. I suspect it happens because it's being opened without the terminal.